8000 API 6.7 by Bibo-Joshi · Pull Request #3673 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

API 6.7 #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
May 7, 2023
Merged

API 6.7 #3673

merged 33 commits into from
May 7, 2023

Conversation

Bibo-Joshi
Copy link
Member
@Bibo-Joshi Bibo-Joshi commented Apr 21, 2023 •
edited
Loading

TODO:

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only

  • Added new shortcuts:

    • [ ] In Chat & User for all methods that accept chat/user_id
    • [ ] In Message for all methods that accept chat_id and message_id
    • [ ] For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • [ ] In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • [ ] Add new message types to Message.effective_attachment
    • [ ] Added new handlers for new update types
      • [ ] Add the handlers to the warning loop in the ConversationHandler
    • [ ] Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • [ ] Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Apr 21, 2023
github-actions[bot]
github-actions bot reviewed Apr 21, 2023
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Bibo-Joshi
Bibo-Joshi commented Apr 21, 2023
View reviewed changes
Bibo-Joshi
Bibo-Joshi commented Apr 21, 2023
View reviewed changes
Bibo-Joshi
Bibo-Joshi commented Apr 22, 2023
View reviewed changes
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 23, 2023
Merged
2 tasks
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 24, 2023
Merged
2 tasks
harshil21
harshil21 reviewed May 5, 2023
View reviewed changes
Copy link
Member
@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question or two:
👇🏽

github-actions[bot]
github-actions bot reviewed May 6, 2023
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review May 6, 2023 19:40
@Bibo-Joshi Bibo-Joshi merged commit 8c252c9 into master May 7, 2023
@Bibo-Joshi Bibo-Joshi deleted the api-6.7 branch May 7, 2023 11:44
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer left review comments

@harshil21 harshil21 harshil21 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bibo-Joshi @Poolitzer @harshil21 @lemontree210
0