8000 Doc fixes by Bibo-Joshi · Pull Request #2969 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]

Skip to content

Doc fixes #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
031dd69
Change version number v14 -> v20
Bibo-Joshi Apr 24, 2022
60b7e81
Overhaul readmes
Bibo-Joshi Apr 24, 2022
03acd34
Update start page of docs
Bibo-Joshi Apr 24, 2022
b6e53d4
Bump doc deps & fix a few dead links
Bibo-Joshi Apr 24, 2022
b76e2a2
remove extra whitespace in timeout docs
harshil21 Apr 26, 2022
f0e3f5a
few doc fixes for bot and inlinequeryhandler
harshil21 Apr 26, 2022
905654c
attempt to add telegram group group logo in footer
harshil21 Apr 27, 2022
93ba835
fix telegram icon and also re-add github icon
harshil21 Apr 27, 2022
3035026
add icon to ptb website and change tg link to channel
harshil21 Apr 27, 2022
045b787
Pimp sidebar and fix heading levels in contrib guide
8000 Bibo-Joshi Apr 27, 2022
2447df3
tiny html_title fix
Bibo-Joshi Apr 27, 2022
885b550
remove all the :github_url: directives b/c furo doesn't support them …
Bibo-Joshi Apr 27, 2022
4bf1e86
Pimp sidebar some more, convert CoC to RST & include it into docs dir…
Bibo-Joshi Apr 28, 2022
90f381d
don't encourage mentioning the admins
harshil21 May 1, 2022
779738f
Add pre-commit CI badge
Bibo-Joshi May 3, 2022
4b3dea3
Merge branch 'v14' into doc-fixes
Bibo-Joshi May 3, 2022
a494ecc
merge v14 and fix conflicts
harshil21 May 4, 2022
bfb014e
add seealso for Bot.initalize and shutdown
harshil21 May 4, 2022
8b8e355
black
harshil21 May 4, 2022
7da174e
Merge branch 'v14' into doc-fixes
Bibo-Joshi May 5, 2022
252f098
get started on documenting generics
Bibo-Joshi May 5, 2022
b9d34e1
finish documentation of generic classes - documented only those that …
Bibo-Joshi May 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/CONTRIBUTING.rst
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
=================
How To Contribute
=================

Every open source project lives from the generous help by contributors that sacrifice their time and ``python-telegram-bot`` is no different. To make participation as pleasant as possible, this project adheres to the `Code of Conduct`_ by the Python Software Foundation.

Setting things up
-----------------
=================

1. Fork the ``python-telegram-bot`` repository to your GitHub account.

Expand Down Expand Up @@ -35,18 +36,18 @@ Setting things up
$ pre-commit install

Finding something to do
#######################
=======================

If you already know what you'd like to work on, you can skip this section.

If you have an idea for something to do, first check if it's already been filed on the `issue tracker`_. If so, add a comment to the issue saying you'd like to work on it, and we'll help you get started! Otherwise, please file a new issue and assign yourself to it.

Another great way to start contributing is by writing tests. Tests are really important because they help prevent developers from accidentally breaking existing code, allowing them to build cool things faster. If you're interested in helping out, let the development team know by posting to the `Telegram group`_ (use `@admins` to mention the maintainers), and we'll help you get started.
Another great way to start contributing is by writing tests. Tests are really important because they help prevent developers from accidentally breaking existing code, allowing them to build cool things faster. If you're interested in helping out, let the development team know by posting to the `Telegram group`_, and we'll help you get started.

That being said, we want to mention that we are very hesitant about adding new requirements to our projects. If you intend to do this, please state this in an issue and get a verification from one of the maintainers.

Instructions for making a code change
#####################################
=====================================

The central development branch is ``master``, which should be clean and ready for release at any time. In general, all changes should be done as feature branches based off of ``master``.

Expand Down Expand Up @@ -93,21 +94,21 @@ Here's how to make a one-off code change.

- Before making a commit ensure that all automated tests still pass:

.. code-block::
.. code-block:: bash

$ pytest -v

To run ``test_official`` (particularly useful if you made API changes), run

.. code-block::
.. code-block:: bash

$ export TEST_OFFICIAL=true

prior to running the tests.

- If you want run style & type checks before committing run

.. code-block::
.. code-block:: bash

$ pre-commit run -a

Expand Down Expand Up @@ -208,10 +209,10 @@ for new to make relevant changes if said lines don't do what they are supposed t


Style commandments
------------------
==================

Assert comparison order
#######################
-----------------------

Assert statements should compare in **actual** == **expected** order.
For example (assuming ``test_call`` is the thing being tested):
Expand All @@ -225,7 +226,7 @@ For example (assuming ``test_call`` is the thing being tested):
assert 5 == test_call()

Properly calling callables
##########################
--------------------------

Methods, functions and classes can specify optional parameters (with default
values) using Python's keyword arg syntax. When providing a value to such a
Expand All @@ -243,7 +244,7 @@ This gives us the flexibility to re-order arguments and more importantly
to add new required arguments. It's also more explicit and easier to read.

Properly defining optional arguments
####################################
------------------------------------

It's always good to not initialize optional arguments at class creation,
instead use ``**kwargs`` to get them. It's well known Telegram API can
Expand Down
27 changes: 16 additions & 11 deletions CODE_OF_CONDUCT.md → CODE_OF_CONDUCT.rst
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# Contributor Covenant Code of Conduct
====================================
Contributor Covenant Code of Conduct
====================================

## Our Pledge
Our Pledge
==========

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards
Our Standards
=============

Examples of behavior that contributes to creating a positive environment include:

Expand All @@ -23,25 +27,26 @@ Examples of unacceptable behavior by participants include:
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities
Our Responsibilities
====================

Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.

## Scope
Scope
=====

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.

## Enforcement
Enforcement
===========

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at devs@python-telegram-bot.org. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

## Attribution
Attribution
===========

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
This Code of Conduct is adapted from the `Contributor Covenant <http://contributor-covenant.org>`_, version 1.4, available at `http://contributor-covenant.org/version/1/4 <http://contributor-covenant.org/version/1/4/>`_.
Loading
0