10000 imlemented crontab based repeating job for jobqueue by marekyggdrasil · Pull Request #1478 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]

Skip to content

imlemented crontab based repeating job for jobqueue #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

marekyggdrasil
Copy link

This is a pull request for a draft implementation of crontab based repeating jobs, more details in following issue where I made my proposal for this feature: #1337

@marekyggdrasil
Copy link
Author

@Bibo-Joshi I understand there is a release plan, I have not abandoned this change, I can see tests are no longer passing due to merges that happen in the meantime.

If you guys decide to merge this PR, just ping me and I'll update the PR to be compatible and mergeable with most recent state of the repo.

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi I understand there is a release plan, I have not abandoned this change, I can see tests are no longer passing due to merges that happen in the meantime.

If you guys decide to merge this PR, just ping me and I'll update the PR to be compatible and mergeable with most recent state of the repo.

Glad to hear! We'll need to figure out what our plan for the next releases is, though, so it will probably take a while until we get back to this PR …

@marekyggdrasil
Copy link
Author

@Bibo-Joshi absolutely, that is understandable, in case if you guys decide to merge it to next release and I won't be responsive feel free to reach me in DM. Good luck!

@Bibo-Joshi
Copy link
Member

TL;DR: Closing in favor of #1981

After internal discussion, we came to the conclusion that we don't want to continue implementing scheduling logic on our own and instead rely on a 3rd party library for that (see #1936, #1981).
One of the upsides is, that a cron logic is already included.
We appreciate the effort that was put in this PR and hope that you'll find the new JobQueue useful once it's finished :)

@Bibo-Joshi Bibo-Joshi closed this Jun 5, 2020
@marekyggdrasil
Copy link
Author

@Bibo-Joshi looking forward to try out the new JobQueue!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0