ci: fix release on moved main #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…started on This change comes because if we merge into main multiple times but the action flow for the first merge was still running it will release on commits that were not considered yet. This happened with `v9.9.0`. This change ensures that the commit that triggered the workflow is the one that has the release decision performed on. This change inline with the concurrency directive should prevent out of order releases from occuring.
|
Validated on with 2 PR resolutions, this PR & PR #1040. As you can see in the run, the correct checkout was the head of the PR after rebased onto main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
This happened for the release of
v9.9.0. I merged 3 PRs within a short time and since the tests were still running I thought I prevented the actual release commit pipeline from running but then the previous pipeline released the new code anyway because it pulled from the branch when the branch had moved during the workflow execution.How did you test?
Unfortunately I won't be able to test this until it happens again. This should fix any issues as it is what I would do manually.