8000 build(deps-dev): update dev dependencies and pre-commit hooks by wyardley · Pull Request #1002 · python-semantic-release/python-semantic-release · GitHub
[go: up one dir, main page]
Skip to content

build(deps-dev): update dev dependencies and pre-commit hooks #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build(deps-dev): update dev dependencies and pre-commit hooks #1002

wants to merge 1 commit into from

Conversation

wyardley
Copy link
Contributor
@wyardley wyardley commented Aug 17, 2024 •
edited
Loading

Purpose

  • Update ruff to v0.6.3
  • Update mypy to v1.11.2
  • Update some pre-commit hooks

Looked at updating pre-commit itself in dev dependencies, however, looks like Python 3.8 (which checks still run on) doesn't support anything after ~ 3.5.

#1009 and #1006 would likely auto-close after this.

Rationale

How did you test?

How to Verify

@wyardley wyardley force-pushed the wyardley/devdeps branch 3 times, most recently from 3e647dd to 55848d3 Compare August 17, 2024 00:47
@wyardley wyardley changed the title build: update dev dependencies and pre-commit hooks build(deps): update dev dependencies and pre-commit hooks Aug 17, 2024
@wyardley wyardley changed the title build(deps): update dev dependencies and pre-commit hooks build: update dev dependencies and pre-commit hooks Aug 17, 2024
@wyardley wyardley changed the title build: update dev dependencies and pre-commit hooks build(deps-dev): update dev dependencies and pre-commit hooks Aug 17, 2024
@wyardley wyardley force-pushed the wyardley/devdeps branch 3 times, most recently from 9942ac6 to b2ef1fb Compare August 23, 2024 19:41
@wyardley
Copy link
Contributor Author

@codejedi365 not time-sensitive, but does this one look reasonable to you?

@wyardley
build(deps-dev): update dev dependencies and pre-commit hooks
cdb550c 
- Update ruff to v0.6.3
- Update mypy to v1.11.2
- Update some pre-commit hooks
@codejedi365
Copy link
Contributor

Hey @wyardley, sorry for the delay, had a lot of changes in my life recently and have not had much time over the past month.

The changes look fine. It's just lower on the priority as it's dev env stuff and I've been wanting to sit down and review the changelogs of the dependencies before introduction. In the grand scheme of things, I would rather that each dependency is bumped in their own commits so that they are distinguishable in the git history in case one causes unforeseen issues. I also already have the dependabot PRs open and would rather add the "pre-commit" update commit added to those branches. So they are in sync.

Does that make sense? Note you can open PRs against other branches not just master.

One hesitancy I have with the constant update of ruff is that it's still not above a 1.0 which means it could have breaking changes which causes more work than it's worth every week when I have bigger features/issues to address. With each bump new rules are added and now I have to update code accordingly with current branches I'm already working and haven't merged in.

I would appreciate it if you desire to make more contributions to more to start tackling some of those "good first issue" tagged issues as I'm really trying to knock down the ticket queue below 70!

@wyardley
Copy link
Contributor Author

Yes, it’s remembering to bump them in sync in pre-commit that’s a pain but that totally makes sense (renovate can do it fwiw)

I think ruff should error in CI now if there are breaking changes that affect the existing code.

and sounds good.

@wyardley wyardley closed this Aug 29, 2024
@wyardley wyardley deleted the wyardley/devdeps branch August 29, 2024 20:36
@codejedi365
Copy link
Contributor

Yes, it’s remembering to bump them in sync in pre-commit that’s a pain but that totally makes sense (renovate can do it fwiw)

It's a pain but I don't really forget that stuff. I've looked into renovate and looks good but have not implemented it yet.

I think ruff should error in CI now if there are breaking changes that affect the existing code.

That's why I have locked in the specific version of ruff (Andy mypy). I don't want an arbitrary bump in version because of flexible pip resolution to cause failures in CI that were not a problem in a previous run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyardley @codejedi365
0