8000 Support new Battery Doorbell device by dan5py · Pull Request #474 · python-ring-doorbell/python-ring-doorbell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@dan5py
Copy link
Contributor
@dan5py dan5py commented Nov 22, 2024

Updates motion detection support for doorbell (Fixes #473)

kind: df_doorbell_clownfish

@sdb9696
Copy link
Member
sdb9696 commented Nov 22, 2024

Is listed somewhere as a Doorbell 4 or is it a new family?

@coveralls
Copy link
coveralls commented Nov 22, 2024

Coverage Status

coverage: 71.103% (-0.07%) from 71.173%
when pulling 4c49728 on dan5py:feat/update-motion-support
into 6ad5112 on python-ring-doorbell:master.

@dan5py
Copy link
Contributor Author
dan5py commented Nov 22, 2024

Not sure if it's a new family, the Ring website marks it as a "2024 model". (btw this is the battery doorbell)

@dan5py
Copy link
Contributor Author
dan5py commented Nov 22, 2024

Maybe it's better to list it under DOORBELL_KINDS instead?

@sdb9696
Copy link
Member
sdb9696 commented Nov 22, 2024

In the device health settings what’s the product name?

@dan5py
Copy link
Contributor Author
dan5py commented Nov 22, 2024

Battery Doorbell

@sdb9696
Copy link
Member
sdb9696 commented Nov 25, 2024

It does seem to be a new product range their calling Battery Doorbell. Could you create a new group DOORBELL_BATTERY_KINDS that returns a model name of "Battery Doorbell" and put it in there?

@sdb9696 sdb9696 added the new-device Support for new devices label Nov 25, 2024
Copy link
Member
@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dan5py!

@sdb9696 sdb9696 changed the title Add motion detection support for new doorbell Support new Battery Doorbell device Nov 25, 2024
@sdb9696 sdb9696 merged commit d277378 into python-ring-doorbell:master Nov 25, 2024
26 checks passed
@sdb9696 sdb9696 mentioned this pull request Nov 26, 2024
sdb9696 added a commit that referenced this pull request Nov 26, 2024
## [0.9.13](https://github.com/python-ring-doorbell/python-ring-doorbell/tree/0.9.13) (2024-11-26)

[Full Changelog](0.9.12...0.9.13)

**Release highlights:**

Support for the new 2024 Battery Doorbell. Many thanks @dan5py!

**Merged pull requests:**

- Support new Battery Doorbell device [\#474](#474) (@dan5py)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new-device Support for new devices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update motion detection support

3 participants

0