Do not expose deprecated attributes to type checkers #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sdb9696
added a commit
that referenced
this pull request
Oct 4, 2024
## [0.9.7](https://github.com/python-ring-doorbell/python-ring-doorbell/tree/0.9.7) (2024-10-04) [Full Changelog](0.9.6...0.9.7) **Release highlights:** - Type checking will now raise errors when using deprecated attributes **Breaking change pull requests:** - Do not expose deprecated attributes to type checkers [\#451](#451) (@sdb9696) **Implemented enhancements:** - Enable keep alive for webrtc stream [\#450](#450) (@sdb9696) **Documentation updates:** - Update README.rst [\#444](#444) (@jamesflores) **Project maintenance:** - Migrate workflows to setup-uv github action [\#449](#449) (@sdb9696)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers still using deprecate attributes will now start getting type checker errors.