Fix in-home chime duration setter #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM!, many thanks @briangoldstein ! |
Merged
sdb9696
added a commit
that referenced
this pull request
Sep 5, 2024
## [0.9.4](https://github.com/python-ring-doorbell/python-ring-doorbell/tree/0.9.4) (2024-09-05) [Full Changelog](0.9.3...0.9.4) **Release highlights:** - Migrate from poetry to uv for package management - Bugfixes for in-home-chime **Implemented enhancements:** - Add WebRTC live streaming session generation [\#348](#348) (@sdb9696) **Fixed bugs:** - Fix in-home chime duration setter [\#428](#428) (@briangoldstein) **Documentation updates:** - Fix broken links in readme [\#426](#426) (@briangoldstein) **Project maintenance:** - Migrate to uv and add testpypi publishing [\#430](#430) (@sdb9696)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async_set_existing_doorbell_type_durationwas checking for the duration to be between 0 and 11, but Ring only accepts 0 through 10 for duration. I added a new set of min/max variables rather than using a different min/max set in order to allow more flexibility in the future.Error from Ring when setting duration to 11: