10000 Only accept missing tkinter when building wheels on Windows by radarhere · Pull Request #8981 · python-pillow/Pillow · GitHub
[go: up one dir, main page]
Skip to content

Only accept missing tkinter when building wheels on Windows #8981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Only accept missing tkinter when building wheels on Windows #8981

merged 1 commit into from
Jun 10, 2025

Conversation

radarhere
Copy link
Member
@radarhere radarhere commented May 27, 2025 •
edited
Loading

Pillow/Tests/check_wheel.py

Lines 14 to 20 in 5a04b95

# tkinter is not available in cibuildwheel installed CPython on Windows
try:
import tkinter
assert tkinter
except ImportError:
expected_modules.remove("tkinter")

Let's increase the specificity of this code to only silently catch the error on Windows, as per the comment.

Since this PR hasn't actually triggered a Wheels job, I'll point to https://github.com/radarhere/Pillow/actions/runs/15235083611 as evidence that this does still pass.

@hugovk hugovk merged commit 6bd5568 into python-pillow:main Jun 10, 2025
78 of 81 checks passed
@radarhere radarhere deleted the windows_wheel branch June 10, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @hugovk
0