fix: check duplicates schemas when loading swagger#157
Open
Marwen94 wants to merge 1 commit intopython-openapi:masterfrom
Open
fix: check duplicates schemas when loading swagger#157Marwen94 wants to merge 1 commit intopython-openapi:masterfrom
Marwen94 wants to merge 1 commit intopython-openapi:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 95.97% 96.09% +0.12%
==========================================
Files 18 18
Lines 547 564 +17
Branches 103 109 +6
==========================================
+ Hits 525 542 +17
Misses 12 12
Partials 10 10
Continue to review full report at Codecov.
|
Author
|
@p1c2u could you please have a look at this PR ? |
Collaborator
|
Looks good. Just wondering how this affects the performance. |
Author
I don't think this influences a lot the performance since it only adds an o(n) complexity where n is the number of schema in a given swagger. Imho n in a real world context is in [1, 100]. We can set the duplicate check optional also, what do you think ? |
835E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156