Specification validation as part of shortcuts #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18cace2 to
5140b73
Compare
5140b73 to
deb54f6
Compare
deb54f6 to
1752d35
Compare
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
- Coverage 91.22% 91.15% -0.08%
==========================================
Files 126 126
Lines 3580 3640 +60
Branches 429 430 +1
==========================================
+ Hits 3266 3318 +52
- Misses 265 273 +8
Partials 49 49
|
|
This seems wasteful since from openapi_core import Spec, validate_request, validate_response
from openapi_core.testing import MockRequest, MockResponse
spec = Spec.from_dict(
{
"openapi": "3.1.0",
"info": {"title": "Test", "version": "1.0.0"},
"paths": {"/": {"get": {"responses": {"200": {"description": "OK"}}}}},
},
)
request = MockRequest("http://localhost", "get", "/")
validate_request(request, spec=spec)
response = MockResponse("")
validate_response(request, response, spec=spec)This adds a very expensive per-request and per-response overhead when the spec is large. Moreover, the documented workaround doesn’t work; this still validates the spec (as can be seen by misspelling from openapi_core import Spec, validate_request, validate_response
from openapi_core.testing import MockRequest, MockResponse
spec = Spec.from_dict(
{
"openapi": "3.1.0",
"info": {"titel": "Test", "version": "1.0.0"},
"paths": {"/": {"get": {"responses": {"200": {"description": "OK"}}}}},
},
validator=None,
)
request = MockRequest("http://localhost", "get", "/")
validate_request(request, spec=spec, spec_validator_cls=None)
response = MockResponse("")
validate_response(request, response, spec=spec, spec_validator_cls=None) |
|
Hi @andersk Guess I need to rethink the change. Thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.