Handle folding of nested defs correctly #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't pull this one yet - it causes a huge slowdown. I'm trying to speed it up. |
95911d1 to
ea0e5d8
Compare
ea0e5d8 to
906eff5
Compare
db26703 to
391ece0
Compare
- Fix folding of code between two defs nested under the same def - Don't search for lines other than def or class in BlockStart because only def and class can contain nested folds - Fix pattern used to find next_def - Fix case where last_block_end is not followed by a blank line
|
I made the logic much faster and added a file length limit above which this new logic is not used, so it doesn't have too much performance impact anymore. |
klen
added a commit
that referenced
this pull request
Nov 26, 2014
Handle folding of nested defs correctly
|
Great work, thank you very much. |
|
Same here. Thanks very much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current folding algorithm, a function definition nested at the top of another function causes the whole outer function to be folded in with the nested function. See #489 for an example. This changeset solves that problem.