8000 Add example of PyMS with metrics by vmjelicic · Pull Request #208 · python-microservices/pyms · GitHub
[go: up one dir, main page]
Skip to content

Add example of PyMS with metrics #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2020
Merged

Add example of PyMS with metrics #208

merged 1 commit into from
Oct 25, 2020

Conversation

vmjelicic
Copy link
Contributor

Close #184

Changes proposed in this PR:

  • Added a new example of PyMS with metrics

@coveralls
Copy link
CFE9 coveralls commented Oct 25, 2020

Pull Request Test Coverage Report for Build 1042

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.134%
Totals Coverage Status
Change from base Build 1040: 0.0%
Covered Lines: 1831
Relevant Lines: 1847
💛 - Coveralls

@avara1986 avara1986 merged commit 5da9906 into master Oct 25, 2020
@avara1986 avara1986 deleted the feature/pyms_metrics_example branch October 25, 2020 21:30
@alexppg
Copy link
Member
alexppg commented Oct 26, 2020

@avara1986 I think there should be some documentation explaining what to expect from examples, what do you think? Without context, it's difficult to understand what you do with this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avara1986 avara1986 avara1986 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example of PyMS with Metrics
4 participants
@vmjelicic @coveralls @alexppg @avara1986
0