8000 Feature/089 namespace on env vars with backward compatibility by rapejim · Pull Request #191 · python-microservices/pyms · GitHub
[go: up one dir, main page]
Skip to content

Feature/089 namespace on env vars with backward compatibility #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 12, 2020
Merged

Feature/089 namespace on env vars with backward compatibility #191

merged 11 commits into from
Oct 12, 2020

Conversation

rapejim
Copy link
Member
@rapejim rapejim commented Oct 12, 2020

Close #89

Changes proposed in this PR:

  • feature: Added namespace to environment variables and legacy versions.
  • feature: Added warnings at use case of old environment variables names.
  • feature: Added backward compatibility at use case of old environment variables names.
  • docs: Added namespace to environment variables on comments and docs.
  • style: changed warning messages for env. vars. deprecated.
  • style: Added new util for apply color or style to text.

@rapejim rapejim requested a review from avara1986 October 12, 2020 14:09
@coveralls
Copy link
coveralls commented Oct 12, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 975

  • 118 of 118 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 99.133%
Totals Coverage Status
Change from base Build 961: 0.05%
Covered Lines: 1830
Relevant Lines: 1846
💛 - Coveralls

avara1986
avara1986 requested changes Oct 12, 2020
View reviewed changes
@rapejim rapejim requested a review from avara1986 October 12, 2020 17:42
@avara1986 avara1986 merged commit 995e476 into master Oct 12, 2020
@avara1986 avara1986 deleted the feature/089-Namespace-on-env-vars-with-backward-compatibility branch October 12, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avara1986 avara1986 avara1986 approved these changes

Assignees
No one assigned
Labels
Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a namespace to all used environment variables
3 participants
@rapejim @coveralls @avara1986
0