8000 support CLOUD_TYPE of AC and prevent future KeyErrrors on lookup by akrherz · Pull Request #69 · python-metar/python-metar · GitHub
[go: up one dir, main page]
Skip to content

support CLOUD_TYPE of AC and prevent future KeyErrrors on lookup #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akrherz merged 1 commit into from
Sep 26, 2018
Merged

support CLOUD_TYPE of AC and prevent future KeyErrrors on lookup #69

akrherz merged 1 commit into from
Sep 26, 2018

Conversation

@akrherz
Copy link
Collaborator
@akrherz akrherz commented Sep 25, 2018

fixes #64

@codecov-io
Copy link
codecov-io commented Sep 25, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   72.88%   72.98%   +0.09%     
==========================================
  Files           4        4              
  Lines        1018     1018              
==========================================
+ Hits          742      743       +1     
+ Misses        276      275       -1
Impacted Files Coverage Δ
metar/Metar.py 66.45% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f092a1b...02223dd. Read the comment docs.

@coveralls
A8BA Copy link
coveralls commented Sep 25, 2018

Pull Request Test Coverage Report for Build 63

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.986%
Totals Coverage Status
Change from base Build 61: 0.1%
Covered Lines: 743
Relevant Lines: 1018
💛 - Coveralls

@akrherz akrherz merged commit dfdc565 into python-metar:master Sep 26, 2018
@akrherz akrherz added this to the 1.7 milestone Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phobson phobson phobson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

AC code should be added to CLOUD_TYPE

4 participants

@akrherz @codecov-io @coveralls @phobson
0