Added a 'COR AUTO' case for modifier #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you, please add your example as a test case. |
Contributor
Author
No problem. Just added a test case. |
Collaborator
|
Thanks, there are some stylistic / nitpicking issues with that test, which I can update if you don't want. Should be spaces between the operators and don't use triple quote for string. I also need to get this repo migrated to github actions, so we can actually have working CI :( |
Collaborator
|
rebased and linted with #125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the modifier re to parse METARs containing a 'COR AUTO' modifier. Makes it possible to parse METARs such as this:
METAR KADW 252356Z COR AUTO 10008KT 10SM CLR 19/11 A2986
RMK AO2 SLP117 T01880111 10230 20188 50004 $ COR
0007=
Fixes #121