8000 Update changelog for 1.13.0 by dalthviz · Pull Request #660 · python-lsp/python-lsp-server · GitHub
[go: up one dir, main page]
Skip to content

Update changelog for 1.13.0 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Update changelog for 1.13.0 #660

merged 2 commits into from
Jul 8, 2025
+34 −0

Conversation

dalthviz
Copy link
Contributor
@dalthviz dalthviz commented Jul 7, 2025

Fixes #659

As a side note, checking the RELEASE.md file Seems like it is outdated? From a quick check, seems like currently what is required, besides the Changelog update PR, is to directly create a GitHub release to trigger the release workflow, right? Also, maybe adding a mention/instructions to update the conda-forge feedstock after the release is available on PyPI could be worthy 🤔 . Anyhow, let me know if making changes to the RELEASE.md makes sense (either here or in another PR after the release) @ccordoba12 !

@dalthviz dalthviz added this to the v1.13.0 milestone Jul 7, 2025
@dalthviz dalthviz self-assigned this Jul 7, 2025
@dalthviz dalthviz added the task label Jul 7, 2025
@dalthviz dalthviz requested a review from ccordoba12 July 7, 2025 18:27
@ccordoba12
Copy link
Member

From a quick check, seems like currently what is required, besides the Changelog update PR, is to directly create a GitHub release to trigger the release workflow, right?

Unfortunately, that's not working but we should fix it so the wheel and tarball are pushed automatically to PyPI. If you have time, you can take a look at that after 1.13 is released.

For now, the release needs to be done manually by tagging the commit corresponding to the Changelog update with the version name (i.e. step 4. in the Release instructions) and following the rest of the steps afterwards.

ccordoba12
ccordoba12 reviewed Jul 7, 2025
View reviewed changes
Copy link
Member
@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion for you @dalthviz.

8000
@dalthviz @ccordoba12
Apply suggestions from code review
fbf6997 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@dalthviz dalthviz requested a review from ccordoba12 July 8, 2025 15:47
@dalthviz
Copy link
Contributor Author
dalthviz commented Jul 8, 2025

I think this is ready @ccordoba12 Let me know if I should merge and proceed with the release or if there is something else to change here

ccordoba12
ccordoba12 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member
@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

Thanks @dalthviz!

@ccordoba12
Copy link
Member

Let me know if I should merge and proceed with the release or if there is something else to change here

I think everything is ready for the release, so please proceed with it.

@dalthviz dalthviz merged commit 8c96441 into python-lsp:develop Jul 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
task
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Release 1.13.0
2 participants
@dalthviz @ccordoba12
0