8000 Drop python 3.7 support by rytilahti · Pull Request #455 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Drop python 3.7 support #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2023
Merged

Drop python 3.7 support #455

merged 6 commits into from
May 17, 2023

Conversation

rytilahti
Copy link
Member

Python 3.7 will become EOL by the end of June '23, so I think we can drop its support whenever a new release gets done.

@codecov-commenter
Copy link
codecov-commenter commented May 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.37 ⚠️

Comparison is base (e7b7f1d) 79.81% compared to head (51cec73) 79.44%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   79.81%   79.44%   -0.37%     
==========================================
  Files          25       25              
  Lines        1897     1897              
  Branches      231      592     +361     
==========================================
- Hits         1514     1507       -7     
- Misses        343      349       +6     
- Partials       40       41       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rytilahti rytilahti marked this pull request as draft May 17, 2023 17:53
@rytilahti rytilahti marked this pull request as ready for review May 17, 2023 17:53
@rytilahti rytilahti added the breaking change Breaking change label May 17, 2023
@rytilahti rytilahti merged commit ce5821a into python-kasa:master May 17, 2023
@rytilahti rytilahti deleted the janitor/drop_py37 branch May 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rytilahti @codecov-commenter
0