-
-
Notifications
You must be signed in to change notification settings - Fork 223
Fix test_deprecated_type stalling #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 82.04% 82.41% +0.36%
==========================================
Files 13 13
Lines 1376 1376
Branches 202 202
==========================================
+ Hits 1129 1134 +5
+ Misses 205 200 -5
Partials 42 42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks 👍
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292) - Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco) **Closed issues:** - KL420L5 controls [\python-kasa#327](python-kasa#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\#292](#292) - Ensure bulb state is restored when turning back on [\#330](#330) (@bdraco) **Closed issues:** - KL420L5 controls [\#327](#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\#331](#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\#325](#325) (@bdraco)
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
The tests were taking a long time to run because this wasn't patched out