8000 Fix test_deprecated_type stalling by bdraco · Pull Request #325 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]

Skip to content

Fix test_deprecated_type stalling #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Mar 24, 2022

The tests were taking a long time to run because this wasn't patched out

@codecov-commenter
Copy link
codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #325 (cf25c75) into master (6f5a60a) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   82.04%   82.41%   +0.36%     
==========================================
  Files          13       13              
  Lines        1376     1376              
  Branches      202      202              
==========================================
+ Hits         1129     1134       +5     
+ Misses        205      200       -5     
  Partials       42       42              
Impacted Files Coverage Δ
kasa/smartdevice.py 86.04% <0.00%> (+0.58%) ⬆️
kasa/cli.py 60.38% <0.00%> (+0.63%) ⬆️
kasa/smartstrip.py 92.30% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5a60a...cf25c75. Read the comment docs.

Copy link
Member
@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍

@rytilahti rytilahti merged commit 2b05751 into python-kasa:master Mar 24, 2022
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on.

[Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3)

**Fixed bugs:**

- Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292)
- Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco)

**Closed issues:**

- KL420L5 controls [\python-kasa#327](python-kasa#327)

**Merged pull requests:**

- Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti)
- Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
@rytilahti rytilahti mentioned this pull request Apr 5, 2022
rytilahti added a commit that referenced this pull request Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on.

[Full Changelog](0.4.2...0.4.3)

**Fixed bugs:**

- Divide by zero when HS300 powerstrip is discovered [\#292](#292)
- Ensure bulb state is restored when turning back on [\#330](#330) (@bdraco)

**Closed issues:**

- KL420L5 controls [\#327](#327)

**Merged pull requests:**

- Update pre-commit hooks to fix black in CI [\#331](#331) (@rytilahti)
- Fix test\_deprecated\_type stalling [\#325](#325) (@bdraco)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0