8000 Improve emeterstatus API, move into own module by rytilahti · Pull Request #205 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Improve emeterstatus API, move into own module #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

Improve emeterstatus API, move into own module #205

merged 1 commit into from
Sep 23, 2021

Conversation

rytilahti
Copy link
Member

Adds the following properties to EmeterStatus for saner API:

  • voltage (in V)
  • power (in W)
  • current (in A)
  • total (in kWh)

@rytilahti
Improve emeterstatus API, move into own module
0f38b22 
Adds the following properties to EmeterStatus for saner API:
* voltage (in V)
* power (in W)
* current (in A)
* total (in kWh)
@codecov-commenter
Copy link
codecov-commenter commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #205 (0f38b22) into master (151976b) will decrease coverage by 0.05%.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   75.04%   74.98%   -0.06%     
==========================================
  Files          11       12       +1     
  Lines        1250     1279      +29     
  Branches      181      181              
==========================================
+ Hits          938      959      +21     
- Misses        273      281       +8     
  Partials       39       39
Impacted Files Coverage Δ
kasa/emeterstatus.py 80.48% <80.48%> (ø)
kasa/__init__.py 100.00% <100.00%> (ø)
kasa/smartbulb.py 94.19% <100.00%> (ø)
kasa/smartdevice.py 82.05% <100.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151976b...0f38b22. Read the comment docs.

@rytilahti
Copy link
Member Author

I'll merge this now as I have pending changes to the homeassistant integration that require this for testing, if there are some changes necessary to the API we can do it in a separate PR.

@rytilahti rytilahti merged commit 36c412a into python-kasa:master Sep 23, 2021
@rytilahti rytilahti deleted the refactor/move_emeterstatus branch September 23, 2021 16:00
@rytilahti rytilahti added the enhancement New feature or request label Sep 23, 2021
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Sep 23, 2021
@rytilahti
Release 0.4.0.dev4
d332303 
The most important enhancements in this release are:
* Support for emeter on strip sockets
* Fix discovery and update() on some devices that do not support multi-module queries (e.g., HS200)
* Improved support for bulbs

[Full Changelog](python-kasa/python-kasa@0.4.0.dev3...0.4.0.dev4)

**Implemented enhancements:**

- HS300 Children plugs have emeter [\python-kasa#64](python-kasa#64)
- Improve emeterstatus API, move into own module [\python-kasa#205](python-kasa#205) ([rytilahti](https://github.com/rytilahti))
- Avoid temp array during encrypt and decrypt [\python-kasa#204](python-kasa#204) ([bdraco](https://github.com/bdraco))
- Add emeter support for strip sockets [\python-kasa#203](python-kasa#203) ([bdraco](https://github.com/bdraco))
- Add own device type for smartstrip children [\python-kasa#201](python-kasa#201) ([rytilahti](https://github.com/rytilahti))
- bulb: allow set\_hsv without v, add fallback ct range [\python-kasa#200](python-kasa#200) ([rytilahti](https://github.com/rytilahti))
- Improve bulb support \(alias, time settings\) [\python-kasa#198](python-kasa#198) ([rytilahti](https://github.com/rytilahti))
- Improve testing harness to allow tests on real devices [\python-kasa#197](python-kasa#197) ([rytilahti](https://github.com/rytilahti))
- cli: add human-friendly printout when calling temperature on non-supported devices [\python-kasa#196](python-kasa#196) ([JaydenRA](https://github.com/JaydenRA))

**Fixed bugs:**

- KL430: Throw error for Device specific information [\python-kasa#189](python-kasa#189)
- dump\_devinfo: handle latitude/longitude keys properly [\python-kasa#175](python-kasa#175) ([rytilahti](https://github.com/rytilahti))

**Closed issues:**

- Feature Request - Toggle Command [\python-kasa#188](python-kasa#188)
- Is It Compatible With HS105? [\python-kasa#186](python-kasa#186)
- Cannot use some functions with KP303 [\python-kasa#181](python-kasa#181)
- Help needed - awaiting game  [\python-kasa#179](python-kasa#179)
- Version inconsistency between CLI and pip [\python-kasa#177](python-kasa#177)
- Release 0.4.0.dev3? [\python-kasa#169](python-kasa#169)
- Discover does not support specifying network interface [\python-kasa#167](python-kasa#167)
- Can't command or query HS200 v5 switch [\python-kasa#161](python-kasa#161)

**Merged pull requests:**

- More CI fixes [\python-kasa#208](python-kasa#208) ([rytilahti](https://github.com/rytilahti))
- Fix CI dep installation [\python-kasa#207](python-kasa#207) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines [\python-kasa#206](python-kasa#206) ([rytilahti](https://github.com/rytilahti))
- Add KP115 fixture [\python-kasa#202](python-kasa#202) ([rytilahti](https://github.com/rytilahti))
- Perform initial update only using the sysinfo query [\python-kasa#199](python-kasa#199) ([rytilahti](https://github.com/rytilahti))
- Add real kasa KL430\(UN\) device dump [\python-kasa#192](python-kasa#192) ([iprodanovbg](https://github.com/iprodanovbg))
- Use less strict matcher for kl430 color temperature [\python-kasa#190](python-kasa#190) ([rytilahti](https://github.com/rytilahti))
- Add EP10\(US\) 1.0 1.0.2 fixture [\python-kasa#174](python-kasa#174) ([nbrew](https://github.com/nbrew))
- Add a note about using the discovery target parameter [\python-kasa#168](python-kasa#168) ([leandroreox](https://github.com/leandroreox))
@rytilahti rytilahti mentioned this pull request Sep 23, 2021
Merged
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Sep 23, 2021
@rytilahti
Release 0.4.0.dev4
a96c566 
The most important enhancements in this release are:
* Support for emeter on strip sockets
* Fix discovery and update() on some devices that do not support multi-module queries (e.g., HS200)
* Improved support for bulbs

[Full Changelog](python-kasa/python-kasa@0.4.0.dev3...0.4.0.dev4)

**Implemented enhancements:**

- HS300 Children plugs have emeter [\python-kasa#64](python-kasa#64)
- Improve emeterstatus API, move into own module [\python-kasa#205](python-kasa#205) ([rytilahti](https://github.com/rytilahti))
- Avoid temp array during encrypt and decrypt [\python-kasa#204](python-kasa#204) ([bdraco](https://github.com/bdraco))
- Add emeter support for strip sockets [\python-kasa#203](python-kasa#203) ([bdraco](https://github.com/bdraco))
- Add own device type for smartstrip children [\python-kasa#201](python-kasa#201) ([rytilahti](https://github.com/rytilahti))
- bulb: allow set\_hsv without v, add fallback ct range [\python-kasa#200](python-kasa#200) ([rytilahti](https://github.com/rytilahti))
- Improve bulb support \(alias, time settings\) [\python-kasa#198](python-kasa#198) ([rytilahti](https://github.com/rytilahti))
- Improve testing harness to allow tests on real devices [\python-kasa#197](python-kasa#197) ([rytilahti](https://github.com/rytilahti))
- cli: add human-friendly printout when calling temperature on non-supported devices [\python-kasa#196](python-kasa#196) ([JaydenRA](https://github.com/JaydenRA))

**Fixed bugs:**

- KL430: Throw error for Device specific information [\python-kasa#189](python-kasa#189)
- dump\_devinfo: handle latitude/longitude keys properly [\python-kasa#175](python-kasa#175) ([rytilahti](https://github.com/rytilahti))

**Closed issues:**

- Feature Request - Toggle Command [\python-kasa#188](python-kasa#188)
- Is It Compatible With HS105? [\python-kasa#186](python-kasa#186)
- Cannot use some functions with KP303 [\python-kasa#181](python-kasa#181)
- Help needed - awaiting game  [\python-kasa#179](python-kasa#179)
- Version inconsistency between CLI and pip [\python-kasa#177](python-kasa#177)
- Release 0.4.0.dev3? [\python-kasa#169](python-kasa#169)
- Discover does not support specifying network interface [\python-kasa#167](python-kasa#167)
- Can't command or query HS200 v5 switch [\python-kasa#161](python-kasa#161)

**Merged pull requests:**

- More CI fixes [\python-kasa#208](python-kasa#208) ([rytilahti](https://github.com/rytilahti))
- Fix CI dep installation [\python-kasa#207](python-kasa#207) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines [\python-kasa#206](python-kasa#206) ([rytilahti](https://github.com/rytilahti))
- Add KP115 fixture [\python-kasa#202](python-kasa#202) ([rytilahti](https://github.com/rytilahti))
- Perform initial update only using the sysinfo query [\python-kasa#199](python-kasa#199) ([rytilahti](https://github.com/rytilahti))
- Add real kasa KL430\(UN\) device dump [\python-kasa#192](python-kasa#192) ([iprodanovbg](https://github.com/iprodanovbg))
- Use less strict matcher for kl430 color temperature [\python-kasa#190](python-kasa#190) ([rytilahti](https://github.com/rytilahti))
- Add EP10\(US\) 1.0 1.0.2 fixture [\python-kasa#174](python-kasa#174) ([nbrew](https://github.com/nbrew))
- Add a note about using the discovery target parameter [\python-kasa#168](python-kasa#168) ([leandroreox](https://github.com/leandroreox))
rytilahti added a commit that referenced this pull request Sep 23, 2021
@rytilahti
Release 0.4.0.dev4 (#210)
bdb07a7 
* Release 0.4.0.dev4

The most important enhancements in this release are:
* Support for emeter on strip sockets
* Fix discovery and update() on some devices that do not support multi-module queries (e.g., HS200)
* Improved support for bulbs

[Full Changelog](0.4.0.dev3...0.4.0.dev4)

**Implemented enhancements:**

- HS300 Children plugs have emeter [\#64](#64)
- Improve emeterstatus API, move into own module [\#205](#205) ([rytilahti](https://github.com/rytilahti))
- Avoid temp array during encrypt and decrypt [\#204](#204) ([bdraco](https://github.com/bdraco))
- Add emeter support for strip sockets [\#203](#203) ([bdraco](https://github.com/bdraco))
- Add own device type for smartstrip children [\#201](#201) ([rytilahti](https://github.com/rytilahti))
- bulb: allow set\_hsv without v, add fallback ct range [\#200](#200) ([rytilahti](https://github.com/rytilahti))
- Improve bulb support \(alias, time settings\) [\#198](#198) ([rytilahti](https://github.com/rytilahti))
- Improve testing harness to allow tests on real devices [\#197](#197) ([rytilahti](https://github.com/rytilahti))
- cli: add human-friendly printout when calling temperature on non-supported devices [\#196](#196) ([JaydenRA](https://github.com/JaydenRA))

**Fixed bugs:**

- KL430: Throw error for Device specific information [\#189](#189)
- dump\_devinfo: handle latitude/longitude keys properly [\#175](#175) ([rytilahti](https://github.com/rytilahti))

**Closed issues:**

- Feature Request - Toggle Command [\#188](#188)
- Is It Compatible With HS105? [\#186](#186)
- Cannot use some functions with KP303 [\#181](#181)
- Help needed - awaiting game  [\#179](#179)
- Version inconsistency between CLI and pip [\#177](#177)
- Release 0.4.0.dev3? [\#169](#169)
- Discover does not support specifying network interface [\#167](#167)
- Can't command or query HS200 v5 switch [\#161](#161)

**Merged pull requests:**

- More CI fixes [\#208](#208) ([rytilahti](https://github.com/rytilahti))
- Fix CI dep installation [\#207](#207) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines [\#206](#206) ([rytilahti](https://github.com/rytilahti))
- Add KP115 fixture [\#202](#202) ([rytilahti](https://github.com/rytilahti))
- Perform initial update only using the sysinfo query [\#199](#199) ([rytilahti](https://github.com/rytilahti))
- Add real kasa KL430\(UN\) device dump [\#192](#192) ([iprodanovbg](https://github.com/iprodanovbg))
- Use less strict matcher for kl430 color temperature [\#190](#190) ([rytilahti](https://github.com/rytilahti))
- Add EP10\(US\) 1.0 1.0.2 fixture [\#174](#174) ([nbrew](https://github.com/nbrew))
- Add a note about using the discovery target parameter [\#168](#168) ([leandroreox](https://github.com/leandroreox))

* replace pypy3 with pypy-3.7 as we do not support python3.6 anyway

* skip pypy-3.7 on windows to avoid flaky ci
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Oct 11, 2021
@rytilahti
Release 0.4.0.dev4 (python-kasa#210)
d5e7aea 
* Release 0.4.0.dev4

The most important enhancements in this release are:
* Support for emeter on strip sockets
* Fix discovery and update() on some devices that do not support multi-module queries (e.g., HS200)
* Improved support for bulbs

[Full Changelog](python-kasa/python-kasa@0.4.0.dev3...0.4.0.dev4)

**Implemented enhancements:**

- HS300 Children plugs have emeter [\python-kasa#64](python-kasa#64)
- Improve emeterstatus API, move into own module [\python-kasa#205](python-kasa#205) ([rytilahti](https://github.com/rytilahti))
- Avoid temp array during encrypt and decrypt [\python-kasa#204](python-kasa#204) ([bdraco](https://github.com/bdraco))
- Add emeter support for strip sockets [\python-kasa#203](python-kasa#203) ([bdraco](https://github.com/bdraco))
- Add own device type for smartstrip children [\python-kasa#201](python-kasa#201) ([rytilahti](https://github.com/rytilahti))
- bulb: allow set\_hsv without v, add fallback ct range [\python-kasa#200](python-kasa#200) ([rytilahti](https://github.com/rytilahti))
- Improve bulb support \(alias, time settings\) [\python-kasa#198](python-kasa#198) ([rytilahti](https://github.com/rytilahti))
- Improve testing harness to allow tests on real devices [\python-kasa#197](python-kasa#197) ([rytilahti](https://github.com/rytilahti))
- cli: add human-friendly printout when calling temperature on non-supported devices [\python-kasa#196](python-kasa#196) ([JaydenRA](https://github.com/JaydenRA))

**Fixed bugs:**

- KL430: Throw error for Device specific information [\python-kasa#189](python-kasa#189)
- dump\_devinfo: handle latitude/longitude keys properly [\python-kasa#175](python-kasa#175) ([rytilahti](https://github.com/rytilahti))

**Closed issues:**

- Feature Request - Toggle Command [\python-kasa#188](python-kasa#188)
- Is It Compatible With HS105? [\python-kasa#186](python-kasa#186)
- Cannot use some functions with KP303 [\python-kasa#181](python-kasa#181)
- Help needed - awaiting game  [\python-kasa#179](python-kasa#179)
- Version inconsistency between CLI and pip [\python-kasa#177](python-kasa#177)
- Release 0.4.0.dev3? [\python-kasa#169](python-kasa#169)
- Discover does not support specifying network interface [\python-kasa#167](python-kasa#167)
- Can't command or query HS200 v5 switch [\python-kasa#161](python-kasa#161)

**Merged pull requests:**

- More CI fixes [\python-kasa#208](python-kasa#208) ([rytilahti](https://github.com/rytilahti))
- Fix CI dep installation [\python-kasa#207](python-kasa#207) ([rytilahti](https://github.com/rytilahti))
- Use github actions instead of azure pipelines [\python-kasa#206](python-kasa#206) ([rytilahti](https://github.com/rytilahti))
- Add KP115 fixture [\python-kasa#202](python-kasa#202) ([rytilahti](https://github.com/rytilahti))
- Perform initial update only using the sysinfo query [\python-kasa#199](python-kasa#199) ([rytilahti](https://github.com/rytilahti))
- Add real kasa KL430\(UN\) device dump [\python-kasa#192](python-kasa#192) ([iprodanovbg](https://github.com/iprodanovbg))
- Use less strict matcher for kl430 color temperature [\python-kasa#190](python-kasa#190) ([rytilahti](https://github.com/rytilahti))
- Add EP10\(US\) 1.0 1.0.2 fixture [\python-kasa#174](python-kasa#174) ([nbrew](https://github.com/nbrew))
- Add a note about using the discovery target parameter [\python-kasa#168](python-kasa#168) ([leandroreox](https://github.com/leandroreox))

* replace pypy3 with pypy-3.7 as we do not support python3.6 anyway

* skip pypy-3.7 on windows to avoid flaky ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rytilahti @codecov-commenter
0