8000 Fix CLI `_echo` without `import rich` for complex objects by mash-graz · Pull Request #1619 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Fix CLI _echo without import rich for complex objects #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mash-graz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix CLI _echo without import rich for complex objects #1619

mash-graz wants to merge 2 commits into from

Conversation

@mash-graz
Copy link
@mash-graz mash-graz commented Nov 29, 2025

Fixes: #1618

@codecov
Copy link
codecov bot commented Nov 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.80%. Comparing base (347bf9a) to head (aa62ede).

Files with missing lines Patch % Lines
kasa/cli/common.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   92.82%   92.80%   -0.02%     
==========================================
  Files         157      157              
  Lines        9643     9645       +2     
  Branches      976      977       +1     
==========================================
  Hits         8951     8951              
- Misses        492      493       +1     
- Partials      200      201       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI _echo doesn't work without import rich for non-String reports

1 participant

@mash-graz
0