E5A4 EST invalid IANA timezone by BrianRossmajer · Pull Request #1554 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

EST invalid IANA timezone #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

EST invalid IANA timezone #1554

wants to merge 1 commit into from

Conversation

BrianRossmajer
Copy link

With 'EST' kasa discover on Debian consistently failed with
Raised error: 'No time zone found with key EST'

I couldn't confirm "EST" was a valid IANA timezone, where America/Toronto definitely is... but it's "Eastern Time" not "Eastern Standard Time" which I think is what folks would expect in any case.

@BrianRossmajer
EST invalid IANA timezone
934f89e 
With 'EST' `discover` consistently failed with
```Raised error: 'No time zone found with key EST'```
@codecov Codecov
Copy link
codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (e21ab90) to head (934f89e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         150      150           
  Lines        9538     9538           
  Branches      974      974           
=======================================
  Hits         8838     8838           
  Misses        499      499           
  Partials      201      201

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rytilahti
Copy link
Member

To be honest, it sounds like your installation is broken. tzdata should have it and I just tested that I can initialize it on python3.13 just fine:

In [3]: from zoneinfo import ZoneInfo

In [4]: ZoneInfo("EST")
Out[4]: zoneinfo.ZoneInfo(key='EST')

You could try if installing tzdata using pip helps. If so, python cannot find the OS-wide installation for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianRossmajer @rytilahti
0