Add missing type hints to alarm module #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1111 +/- ##
=======================================
Coverage 92.55% 92.55%
=======================================
Files 96 96
Lines 6100 6101 +1
Branches 1504 1504
=======================================
+ Hits 5646 5647 +1
Misses 354 354
Partials 100 100 ☔ View full report in Codecov by Sentry. |
sdb9696
approved these changes
Sep 6, 2024
Collaborator
There was a problem hiding this comment.
I wonder whether the alarm volume should be an enum for the sake of API clarity but it's up to you
Merged
sdb9696
added a commit
that referenced
this pull request
Sep 10, 2024
## [0.7.3](https://github.com/python-kasa/python-kasa/tree/0.7.3) (2024-09-10) [Full Changelog](0.7.2...0.7.3) **Release summary:** - Migrate from `poetry` to `uv` for package/project management. - Various minor code improvements **Project maintenance:** - Do not regenerate aes key pair [\#1114](#1114) (@sdb9696) - Fix tests due to yarl URL str output change [\#1112](#1112) (@sdb9696) - Add missing type hints to alarm module [\#1111](#1111) (@rytilahti) - Add KH100 EU fixtures [\#1109](#1109) (@rytilahti) - Migrate from poetry to uv for dependency and package management [\#986](#986) (@sdb9696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typing issues for home-assistant/core#124934