8000 Add missing type hints to alarm module by rytilahti · Pull Request #1111 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]

Skip to content

Add missing type hints to alarm module #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

rytilahti
Copy link
Member

Fixes typing issues for home-assistant/core#124934

@rytilahti rytilahti added the maintenance Project improvements and maintenance label Sep 5, 2024
Copy link
codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (4ef7306) to head (27890df).
Report is 179 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1111   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          96       96           
  Lines        6100     6101    +1     
  Branches     1504     1504           
=======================================
+ Hits         5646     5647    +1     
  Misses        354      354           
  Partials      100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti removed the maintenance Project improvements and maintenance label Sep 6, 2024
@rytilahti rytilahti requested a review from sdb9696 September 6, 2024 12:50
Copy link
Collaborator
@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the alarm volume should be an enum for the sake of API clarity but it's up to you

@sdb9696 sdb9696 merged commit 2a89e58 into master Sep 10, 2024
30 checks passed
@sdb9696 sdb9696 deleted the janitor/add_missing_types_to_alarm branch September 10, 2024 16:20
@sdb9696 sdb9696 added this to the 0.7.3 milestone Sep 10, 2024
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Sep 10, 2024
@sdb9696 sdb9696 mentioned this pull request Sep 10, 2024
sdb9696 added a commit that referenced this pull request Sep 10, 2024
## [0.7.3](https://github.com/python-kasa/python-kasa/tree/0.7.3) (2024-09-10)

[Full Changelog](0.7.2...0.7.3)

**Release summary:**

- Migrate from `poetry` to `uv` for package/project management.
- Various minor code improvements

**Project maintenance:**

- Do not regenerate aes key pair [\#1114](#1114) (@sdb9696)
- Fix tests due to yarl URL str output change [\#1112](#1112) (@sdb9696)
- Add missing type hints to alarm module [\#1111](#1111) (@rytilahti)
- Add KH100 EU fixtures [\#1109](#1109) (@rytilahti)
- Migrate from poetry to uv for dependency and package management [\#986](#986) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project improvements and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0