Use calendar.timegm instead of time.mktime for UTC timestamps #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time.mktime() converts a time tuple in local time to seconds since the Epoch, as stated in the docs: > Convert a time tuple in local time to seconds since the Epoch. > Note that mktime(gmtime(0)) will not generally return zero for most > time zones; instead the returned value will either be equal to that > of the timezone or altzone attributes on the time module. calendar.timegm() is guaranteed to produce UTC timestamp: > Unrelated but handy function to calculate Unix timestamp from GMT.
|
Thanks for this fix! I took some time to poke around and see if there's any other interface which provides this -- it feels weird to import I need to add a test which demonstrates the issue before I can merge, and there are issues in CI related to the lastest |
sirosen
added a commit
that referenced
this pull request
May 18, 2025
sirosen
added a commit
that referenced
this pull request
May 18, 2025
* Use calendar.timegm instead of time.mktime for UTC timestamps time.mktime() converts a time tuple in local time to seconds since the Epoch, as stated in the docs: > Convert a time tuple in local time to seconds since the Epoch. > Note that mktime(gmtime(0)) will not generally return zero for most > time zones; instead the returned value will either be equal to that > of the timezone or altzone attributes on the time module. calendar.timegm() is guaranteed to produce UTC timestamp: > Unrelated but handy function to calculate Unix timestamp from GMT. * Add a regression test for localtime handling * Add changelog entry for #565 --------- Co-authored-by: Radosław Kozicki <rkpraca@posteo.net>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.mktime() converts a time tuple in local time to seconds since the Epoch, as stated in the docs:
calendar.timegm() is guaranteed to produce UTC timestamp: