8000 WIP: migrate to asyncio and httpx by L0ric0 · Pull Request #998 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]
Skip to content

WIP: migrate to asyncio and httpx #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

WIP: migrate to asyncio and httpx #998

wants to merge 9 commits into from

Conversation

L0ric0
Copy link
@L0ric0 L0ric0 commented Jan 22, 2020 •
edited
Loading

starting to migrate to async while staying compatible to the syncronous versions.

TODO:

  • rewrite GitlabList init to be async compatible
  • find all functions that need a async_ version

which funktions are suposed to be called by the user? if possible i would like to keep all internal funktions async and run the functions that have to be sync with run_until_complete()

would it be better to have a centrel event_loop instead of getting it with get_event_loop every time and if so where would i put it?

fix #945

@L0ric0
Copy link
Author
L0ric0 commented Jan 28, 2020

at the moment the httpx module dose not support auth in the httpx.Request object and doesn't supply a client.prepare_request method so that the http_request method in __init__.py doesn't work. Does somebody know of an alternative?

@L0ric0 L0ric0 requested a review from max-wittig January 28, 2020 17:42
@max-wittig
Copy link
Member

Thanks for all the efforts on this. Maybe we should wait until the 1.0 release of https in April?

A 1.0 release is expected to be issued sometime on or before April 2020.`

@L0ric0
Copy link
Author
L0ric0 commented Feb 12, 2020

yeah probably hopefully they fix the two issues that are blocking this pr
< 8000 form class="js-comment-update" id="issuecomment-585395128-edit-form" data-turbo="false" action="/python-gitlab/python-gitlab/issue_comments/585395128" accept-charset="UTF-8" method="post">

@vishes-shell vishes-shell mentioned this pull request Feb 22, 2020
Open
@darkdragon-001
Copy link

Can you check if httpx version 1.0.0.beta0 fixes the remaining issues?

@JohnVillalovos
Copy link
Member

No activity in almost two years from the author. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate to asyncio
4 participants
@L0ric0 @max-wittig @darkdragon-001 @JohnVillalovos
0