8000 Improve error message handling in exceptions by gpocentek · Pull Request #641 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]
Skip to content

Improve error message handling in exceptions #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

Improve error message handling in exceptions #641

merged 1 commit into from
Nov 28, 2018

Conversation

gpocentek
Copy link
Contributor
  • Depending on the request Gitlab has a 'message' or 'error' attribute
    in the json data, handle both
  • Add some consistency by converting messages to unicode or str for
    exceptions (depending on the python version)

Closes #616

Improve error message handling in exceptions
1fb1296 
* Depending on the request Gitlab has a 'message' or 'error' attribute
in the json data, handle both
* Add some consistency by converting messages to unicode or str for
exceptions (depending on the python version)

Closes #616
@max-wittig max-wittig merged commit 7bd41cb into master Nov 28, 2018
@gpocentek gpocentek deleted the refactor/excpetion_msg branch June 20, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpocentek @max-wittig
0