Update groups.rst #3095
Open
Update groups.rst #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added docs example get all group members + access level
nejch
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks a lot for your contribution @rnelson01!
The commit message will need to be changed to pass our CI, see our contribution guidelines if you need help. I just have one additional question as well.
| @@ -288,6 +288,15 @@ ancestor groups):: | |||
|
|
|||
| members = group.members_all.list(get_all=True) | |||
|
|
|||
| List all groups and all group member with access level:: | |||
There was a problem hiding this comment.
This feels like it's covering a bit more than just the group members API and almost like a small cookbook example. WDYT about narrowing it down to just the API calls for members, or moving this example to a separate documentation page for longer examples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added docs example get all group members + access level
Changes
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: