8000 fix(ci): do not rely on GitLab.com runner arch variables by nejch · Pull Request #3003 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]

Skip to content

fix(ci): do not rely on GitLab.com runner arch variables #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

nejch
Copy link
Member
@nejch nejch commented Sep 30, 2024

See https://gitlab.com/python-gitlab/python-gitlab/-/jobs/7943404960 (aarch64 runner), seems like they run their ARM runners with an AMD64 helper binary/host.

Resulted in a failure on multi-arch build =>https://gitlab.com/python-gitlab/python-gitlab/-/jobs/7943404962

Also upstream docs:

The OS/architecture of the GitLab Runner executable. Might not be the same as the environment of the executor.

Copy link
Member
@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @nejch

@nejch
Copy link
Member Author
nejch commented Sep 30, 2024

Thanks for the review @JohnVillalovos 🙇

@nejch nejch merged commit c848d12 into main Sep 30, 2024
18 checks passed
@nejch nejch deleted the fix/gitlab-os-arch branch September 30, 2024 17:32
@nejch
Copy link
Member Author
nejch commented Sep 30, 2024

I'll try to release this now to see if it works and also to get #2998 back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0