adds project upload feature #239
Conversation
Needs unit tests still. see python-gitlab#56
|
Attaching files to issues and issue notes seems to be working well though, now I'm trying to figure out the best way to do unit tests for this. |
|
Cool addition 👍 I need a bit more time to test/digest the code. If you spend time on this I'd rather have functional tests to get examples of how to use the code ( Thanks you! |
|
Totally! Wanted to push up the raw features while I figured out the unit
tests. I'll see if I can add some today.
…On Mar 21, 2017 01:28, "Gauvain Pocentek" ***@***.***> wrote:
Cool addition 👍
I need a bit more time to test/digest the code. If you spend time on this
I'd rather have functional tests to get examples of how to use the code (
tools/python_test.py).
Thanks you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#239 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE2rYs5hReef3tsgX-9vCvgvgGTgb0n3ks5rn24PgaJpZM4Mg6t5>
.
|
|
Any updates on this? |
|
@aruiz Sorry but I didn't have enough time to properly review and test this patch. Hopefully things will get better soon. |
|
Is there anything else we need to do on this? Finally getting back to it |
|
Hi @d0c-s4vage, sorry for not answering sooner. I didn't take time to test an upload yet, but the code itself seems OK to me. I'm not sure that python-gitlab should be responsible of adding the markdown in the issues/notes description. User will probably want to handle that part themselves (at the beginning, at the end, new note or existing one, ...). The Mixin class is probably not needed If you have time to implement this for v4 it would be great, but I can take care of it if you don't. Thanks for adding this feature! |
|
@gpocentek ah, great point on that. It's been a while since I've looked at my changes... I'll make the file upload/attachment a stand-alone feature that can return/generate markdown for the user. |
|
well crap, that rebase didn't work out how I thought it would. SHould've merged instead of rebased. |
eab48ce to
1ce40a3
Compare
|
Feature branch is now up-to-date with latest from python-gitlab/python-gitlab |
see python-gitlab#56 * file uploads are not directly associated with issues/notes * should work with v3 and v4 apis * CLIs seem to be working
|
@gpocentek pending review/comments, I think this is done |
|
Thanks for the update! I really appreciate the docs and tests! :) It looks pretty good to me, I'm just wondering if the |
|
Hrmm, good point. I made the Also, I don't know why the build is failing on python2.7 cli_func_v4. I'll take another look and see if my code interfered with branch creation somehow: |
|
@gpocentek w00t! all tests are passing, I think this is good to go now. |
|
Thank for your patience and the quality of this patch! |
|
Awesome! We're glad to contribute - we use python-gitlab pretty heavily |
Needs unit tests still. see #56