fix: iterator possible breaking change #2107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b644721 inadvertently introduced a possible breaking change as it added a new argument `iterator` and added it in between existing positional arguments. Move the `iterator` argument to the end of the argument list and also require it to be a keyword-only argument.
Codecov Report
@@ Coverage Diff @@
## main #2107 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 78 78
Lines 5087 5087
=======================================
Hits 4819 4819
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Jun 27, 2022
|
I just changed this to a refactor so it doesnt show up in the changelog as it does not affect a released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b644721 inadvertently
introduced a possible breaking change as it added a new argument
iteratorand added it in between existing positional arguments.Move the
iteratorargument to the end of the argument list and alsorequire it to be a keyword-only argument.