8000 feat(user): support getting user SSH key by id by nejch · Pull Request #1962 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]
Skip to content

feat(user): support getting user SSH key by id #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

feat(user): support getting user SSH key by id #1962

merged 1 commit into from
Apr 13, 2022

Conversation

nejch
Copy link
Member
@nejch nejch commented Apr 1, 2022

@nejch nejch force-pushed the feat/user-ssh-key branch from d9bbee2 to 6f93c05 Compare April 1, 2022 20:03
@nejch nejch changed the title feat(users): support getting user SSH key by id feat(user): support getting user SSH key by id Apr 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1962 (6f93c05) into main (d508b18) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          78       78           
  Lines        4900     4902    +2     
=======================================
+ Hits         4535     4537    +2     
  Misses        365      365
Flag Coverage Δ
cli_func_v4 81.68% <66.66%> (-0.02%) ⬇️
py_func_v4 80.23% <100.00%> (+<0.01%) ⬆️
unit 83.43% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/users.py 95.94% <100.00%> (+0.03%) ⬆️

@nejch nejch requested a review from JohnVillalovos April 5, 2022 07:19
@nejch nejch requested a review from max-wittig April 13, 2022 06:08
@max-wittig max-wittig merged commit 68bf5d8 into main Apr 13, 2022
@max-wittig max-wittig deleted the feat/user-ssh-key branch April 13, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos Awaiting requested review from JohnVillalovos

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nejch @codecov-commenter @max-wittig
0