8000 feat(objects): add support for Group wikis by spamsch · Pull Request #1484 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]
Skip to content

feat(objects): add support for Group wikis #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2021
Merged

feat(objects): add support for Group wikis #1484

merged 6 commits into from
Jun 2, 2021

Conversation

spamsch
Copy link
Contributor
@spamsch spamsch commented May 30, 2021 •
edited by nejch
Loading

This pull request adds support for wikis on Group level

Closes #1224

JohnVillalovos
JohnVillalovos requested changes May 30, 2021
View reviewed changes
@JohnVillalovos
Copy link
Member

Thanks for this PR!

I left a few comments, but overall it is looking great 👍

@codecov-commenter
Copy link
codecov-commenter commented May 30, 2021 •
edited
Loading

Codecov Report

Merging #1484 (2935e62) into master (fbbc0d4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   90.98%   91.00%   +0.02%     
==========================================
  Files          73       73              
  Lines        4080     4091      +11     
==========================================
+ Hits         3712     3723   
8000
   +11     
  Misses        368      368
Flag Coverage Δ
cli_func_v4 80.66% <100.00%> (+0.05%) ⬆️
py_func_v4 80.02% <100.00%> (+0.05%) ⬆️
unit 82.18% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/groups.py 83.67% <100.00%> (+0.16%) ⬆️
gitlab/v4/objects/wikis.py 100.00% <100.00%> (ø)

@spamsch spamsch requested a review from JohnVillalovos May 31, 2021 07:16
@max-wittig
Copy link
Member

Would it be possible for you to add some unit tests as well for this?

@spamsch
Copy link
Contributor Author
spamsch commented May 31, 2021

Would it be possible for you to add some unit tests as well for this?

There are no unit tests for project wikis. Not sure it makes sense to have unit tests for groups only. Could think about adding functional tests. Makes sense?

@nejch
Copy link
Member
nejch commented May 31, 2021 •
edited
Loading

Would it be possible for you to add some unit tests as well for this?

There are no unit tests for project wikis. Not sure it makes sense to have unit tests for groups only. Could think about adding functional tests. Makes sense?

I just triggered the workflow. Group Wikis are a Premium/EE feature so let's see if this works in the CE container 😁 And you're right, we'd need to create a new test_wikis.py module with a group wiki mock response for this. There are examples in other modules if the functional tests fail (if it fails, maybe add @pytest.mark.skip to the functional test that you added, for now).

Edit: it failed (gitlab.exceptions.GitlabCreateError: 404: 404 Not Found), so maybe add a skip marker and if you need any help with unit tests let us know :)

@JohnVillalovos
Copy link
Member

FYI: Running tox -e black locally should resolve the black formatting issues.

@JohnVillalovos
Copy link
Member

Thanks a lot @spamsch 😊

Looks good to me. Personally I would like it if it was rebased and squashed. As right now there are six commits and one of them is a merge commit. I think it will make the project history be better if it was rebased and squashed.

Not sure what @nejch and @max-wittig think.

@nejch
Copy link
Member
nejch commented Jun 1, 2021

Thanks a lot @spamsch 😊

Looks good to me. Personally I would like it if it was rebased and squashed. As right now there are six commits and one of them is a merge commit. I think it will make the project history be better if it was rebased and squashed.

Not sure what @nejch and @max-wittig think.

Ok, i can also squash on merge and add the unit tests along with project wiki tests in a follow-up. Just not from my phone on my commute right now.. :D

@nejch nejch mentioned this pull request Jun 2, 2021
Closed
@nejch nejch merged commit 74f5e62 into python-gitlab:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos Awaiting requested review from JohnVillalovos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Is Group wikis supported?
5 participants
@spamsch @JohnVillalovos @codecov-commenter @max-wittig @nejch
0