8000 chore(ci): automate releases by nejch · Pull Request #1427 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]

Skip to content

chore(ci): automate releases #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

chore(ci): automate releases #1427

merged 1 commit into from
May 10, 2021

Conversation

nejch
Copy link
Member
@nejch nejch commented Apr 28, 2021

Adds an automated release every week once a month + manual workflow if quick fixes are needed. I thought this would be a good compromise. I didn't want this on every push as otherwise all release notes just have only 1 PR entry and it's just really noisy. I see other people are also reconsidering that: renovatebot/renovate#9709.

Also I just chose Monday so there's no Friday releases 🤣 but open to suggestions.

I tested this here (including all my derpy trial&error pushes):
https://github.com/nejch/python-gitlab-semantic-release

Resulting releases: https://github.com/nejch/python-gitlab-semantic-release/releases
testpypi package: https://test.pypi.org/project/python-gitlab/
changelog: https://github.com/nejch/python-gitlab-semantic-release/blob/master/CHANGELOG.md

I've also already set up the PYPI_TOKEN secret here.

Initially I wasn't a fan of the auto-committed CHANGELOG.md but now I'm thinking it gives us a chance to consolidate the old changelog and release notes that are just sitting there since the GH Releases move. I can push another PR for that to add the old changes it to the new changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #1427 (6f61a1c) into master (98891eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files          73       73           
  Lines        4064     4064           
=======================================
  Hits         3261     3261           
  Misses        803      803           
Flag Coverage Δ
unit 80.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98891eb...6f61a1c. Read the comment docs.

@nejch nejch marked this pull request as ready for review April 28, 2021 22:51
@nejch nejch requested a review from max-wittig April 28, 2021 22:52
@max-wittig
Copy link
Member

Often it's not really required to release every week. Gitlab releases every month. Maybe that makes more sense? To release shortly after Gitlab's monthly release?

@nejch
Copy link
Member Author
nejch commented May 2, 2021

Often it's not really required to release every week. Gitlab releases every month. Maybe that makes more sense? To release shortly after Gitlab's monthly release?

Ok, makes sense 👍 Originally I was thinking so that people don't have to wait after things get merged as they are sometimes asking in PRs, but it might get too spammy for others like that. I'll change the cron for the end of the month.

@nejch nejch force-pushed the chore/automate-releases branch from 6f61a1c to 0ef497e Compare May 3, 2021 17:11
@nejch
Copy link
Member Author
nejch commented May 3, 2021

I've reworded this and made the cron schedule to be on the 28th of the month, that should give us a few days after the 22nd to add some popular features after a GitLab release.

Copy link
Member
@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@max-wittig max-wittig merged commit 25695d9 into master May 10, 2021
@nejch nejch deleted the chore/automate-releases branch May 30, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0