8000 fix: argument type was not a tuple as expected by JohnVillalovos · Pull Request #1399 · python-gitlab/python-gitlab · GitHub
[go: up one dir, main page]
Skip to content

fix: argument type was not a tuple as expected #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix: argument type was not a tuple as expected #1399

merged 1 commit into from
Apr 19, 2021

Conversation

JohnVillalovos
Copy link
Member

While adding type-hints mypy flagged this as an issue. The third
argument to register_custom_action is supposed to be a tuple. It was
being passed as a string rather than a tuple of strings.

@JohnVillalovos
fix: argument type was not a tuple as expected
062f8f6 
While adding type-hints mypy flagged this as an issue. The third
argument to register_custom_action is supposed to be a tuple. It was
being passed as a string rather than a tuple of strings.
@codecov-commenter
Copy link

Codecov Report

Merging #1399 (062f8f6) into master (916a7fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1399   +/-   ##
=======================================
  Coverage   80.16%   80.16%           
=======================================
  Files          73       73           
  Lines        4073     4073           
=======================================
  Hits         3265     3265           
  Misses        808      808
Flag Coverage Δ
unit 80.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/merge_requests.py 65.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916a7fe...062f8f6. Read the comment docs.

@max-wittig
Copy link
Member

That mistake happens too often in Python 😄

LGTM 👍

@max-wittig max-wittig merged commit fc4f7fd into python-gitlab:master Apr 19, 2021
@JohnVillalovos
Copy link
Member Author

That mistake happens too often in Python 😄

One of the things I like with adding the static type-hints and then using mypy. That is how I caught this one. May find more issues as more and more type-hints are added.

@JohnVillalovos JohnVillalovos deleted the jlvillal/fix_custom_action branch April 20, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @codecov-commenter @max-wittig
0