8000 Fix examples by bnavigator · Pull Request #965 · python-control/python-control · GitHub
[go: up one dir, main page]
Skip to content

Fix examples #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2024
Merged

Fix examples #965

merged 3 commits into from
Jan 23, 2024

Conversation

bnavigator
Copy link
Contributor

Conda deployed scipy 1.12 and the examples job started to fail with

ImportError: cannot import name 'pi' from 'scipy'

  • Use the officially documented NumPy API instead.
  • Use the opportunity to escape two unescaped strings with LaTeX formatted labels.

@coveralls
Copy link
coveralls commented Jan 22, 2024 •
edited
Loading

Coverage Status

coverage: 94.784%. remained the same
when pulling 2c32913 on bnavigator:fix-examples
into a8a54d1 on python-control:main.

@bnavigator bnavigator marked this pull request as ready for review January 22, 2024 20:58
@murrayrm
Copy link
Member

LGTM.

@bnavigator bnavigator merged commit 85328d9 into python-control:main Jan 23, 2024
@bnavigator bnavigator mentioned this pull request Jan 28, 2024
Closed
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @murrayrm
0