Margin fix #66
Merged
Margin fix #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
control.margins.margin() was returning the gain and phase margin frequencies in the wrong order. Added TestMargin.test_margin, duplicating test case from TestMargin.test_stability_margins, in margin_test.py, and unskipped TestMatlab.testCombi01 in matlab_test.py.
Revert gain and phase frequency swap in TestMatlab.testCombi01. Correct TestMatlab.testMargin.
repagh
added a commit
that referenced
this pull request
Jul 11, 2015
Margin fix You are right on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward fix to margin.
The related tests have some odd properties, e.g., TestMargin in margin_test.py has four test systems, but only checks the results for one of them; and similarly TestMatlab.testMargin() runs margin() on five systems, but only checks one result.
Oh, and apologies for the two commits; I didn't run the full test suite before the first commit.