10000 change u == 0 test to avoid py3.8+ syntax warning by murrayrm · Pull Request #580 · python-control/python-control · GitHub
[go: up one dir, main page]
Skip to content

change u == 0 test to avoid py3.8+ syntax warning #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

change u == 0 test to avoid py3.8+ syntax warning #580

merged 1 commit into from
Mar 20, 2021

Conversation

murrayrm
Copy link
Member

PR #546 introduced a test of the form u == 0 that generates a SyntaxWarning in Python 3.8+. I changed this to set u to None by default and then check for u is None. A good description of the reason for the warning is here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.14% when pulling 89dcf3c on murrayrm:fix_is_py3.8+ into 55d7e2b on python-control:master.

@sawyerbfuller
Copy link
Contributor

good catch, thanks. just so easy to write 'is' by accident in such cases, I thought i had gotten it out of my system but I guess not. : )

@sawyerbfuller sawyerbfuller merged commit 992bf0e into python-control:master Mar 20, 2021
@murrayrm murrayrm deleted the fix_is_py3.8+ branch March 20, 2021 04:00
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@murrayrm @coveralls @sawyerbfuller
0