8000 Make output response matrices consistent between continuous and discrete time by murrayrm · Pull Request #143 · python-control/python-control · GitHub
[go: up one dir, main page]
Skip to content

Make output response matrices consistent between continuous and discrete time #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2017
Merged

Make output response matrices consistent between continuous and discrete time #143

merged 2 commits into from
Apr 21, 2017

Conversation

murrayrm
Copy link
Member

This PR addresses issue #142 where the output response matrices were not consistent for continuous and discrete time simulations. The error was in the discrete time simulation, where the conventions used by spicy.signal are different than those used by python-control. Also added a unit test that catches this error.

@coveralls
Copy link
coveralls commented Apr 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 77.344% when pulling 1adfaf0 on murrayrm:timeresp-discrete-retval-fix into 6ada795 on python-control:master.

@murrayrm murrayrm requested a review from slivingston April 15, 2017 18:11
@murrayrm murrayrm mentioned this pull request Apr 15, 2017
Closed
roryyorke
roryyorke reviewed Apr 18, 2017
View reviewed changes
Copy link
Contributor
@roryyorke roryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I suppose one could test each of control.timeresp's public functions (this fixes all of them), but it's hardly necessary.

@murrayrm
Copy link
Member Author

Thanks for the review, @roryyorke. Merging into master.

@murrayrm murrayrm merged commit e3c0f79 into python-control:master Apr 21, 2017
@murrayrm murrayrm deleted the timeresp-discrete-retval-fix branch April 21, 2017 14:49
@murrayrm murrayrm added this to the 0.8.0 milestone Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryyorke roryyorke roryyorke left review comments

@slivingston slivingston Awaiting requested review from slivingston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@murrayrm @coveralls @roryyorke
0