Handle scalar timeresp in solve_flat_ocp
#1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
reviewed
Feb 1, 2025
control/tests/flatsys_test.py
Outdated
Comment on lines
473
to
475
| assert np.max(abs(r1.x-r2.x)) == 0 | ||
| assert np.max(abs(r1.u-r2.u)) == 0 | ||
| assert np.max(abs(r1.y-r2.y)) == 0 |
There was a problem hiding this comment.
Is this a fancy way to say r1.x == r2.x while employing some opaque shape casting?
There was a problem hiding this comment.
just laziness! fixed.
|
the failures are during |
|
Reran the tests and that fixed the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1110.