Fix td04ad_case1 and td04ad_static tests #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 10, 2020 12:15
this fixes a fail of the test on powerpc architecture
Closed
Collaborator
Author
|
@roryyorke FWIW, you don't need to rebase everything. Just merge into master and resolve the conflicts. |
8255cb4 to
5ee39f8
Compare
Collaborator
|
I like the cleaner history with rebasing. AFAICT it's no harder than merging. Anyway, this looks good, thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_td04ad_case1andtest_td04ad_staticfailed on ARM and PowerPC architectures while packaging for OpenSUSE. No sure if anyone acually uses it, maybe some experimental control application on a Raspberry Pi or similar.I dug into the case1 test a bit and came out with two tests splitting the 'C' and 'R' option.
The static test now also checks the result of the call and is moved to the
test_td04ad.pyfile.On the way I found some typos, removed some pep8 issues, and corrected the documentation API call line for
td04ad().