8000 Remove deprecated setup.py calls by bnavigator · Pull Request #173 · python-control/Slycot · GitHub
[go: up one dir, main page]

Skip to content
8000

Conversation

@bnavigator
Copy link
Collaborator
@bnavigator bnavigator commented May 2, 2022

Setuptools deprecated their command line interface through setup.py and wants to be a pure PEP517 backend.

This also fixes #172 and closes #163

@bnavigator bnavigator force-pushed the update-pip+conda branch 3 times, most recently from a044027 to f264ffc Compare May 2, 2022 16:14
@roryyorke
Copy link
Collaborator

Changes look good in principle. I'm afraid I can't offer much advice on the Windows build failures.

I won't be available for more review until Saturday at the earliest, and I can't guarantee that. Feel free to merge when you're done.

@bnavigator
Copy link
Collaborator Author
bnavigator commented May 3, 2022

We have to defer the replacement in the conda recipe for Windows: scikit-build/scikit-build#705

Would still like to follow through with the Linux and Mac build, as it fixes #172

@bnavigator bnavigator merged commit f296b17 into python-control:master May 3, 2022
@bnavigator bnavigator deleted the update-pip+conda branch May 3, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conda MacOS CI failures Update conda testing in CI

2 participants

0