This repository was archived by the owner on Jan 4, 2025. It is now read-only.
Simplified remove_empty #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Instead of mutating a dict building a new one is better. Should be faster than using del and safe. Also casting a set of dict.keys is not necessary, keys in a dict are always unique.
jameshiew
reviewed
Jun 15, 2017
mws/mws.py
Outdated
| if not d[key]: | ||
| del d[key] | ||
| return d | ||
| return {k: v for k, v in d.items() if not v} |
Contributor
There was a problem hiding this comment.
if v rather than if not v
Contributor
|
Nice, definitely a much simpler way of doing it, let's remove the |
Contributor
Author
|
Sry, my fault. |
Codecov Report
@@ Coverage Diff @@
## develop #8 +/- ##
==========================================
Coverage ? 47.31%
==========================================
Files ? 4
Lines ? 391
Branches ? 23
==========================================
Hits ? 185
Misses ? 197
Partials ? 9
Continue to review full report at Codecov.
|
Contributor
|
Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mutating a dict building a new one is better. Should be faster than using del and safe. Also casting a set of dict.keys is not necessary, keys in a dict are always unique.