This repository was archived by the owner on Jan 4, 2025. It is now read-only.
Refactor/request description #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it can be tested more easily, and refactored
So that it can be tested more easily
So that it is easier to debug
Codecov Report
@@ Coverage Diff @@
## develop #29 +/- ##
========================================
+ Coverage 48.85% 50% +1.14%
========================================
Files 4 4
Lines 393 402 +9
Branches 22 22
========================================
+ Hits 192 201 +9
Misses 192 192
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the
request_descriptionone liner into it's own function, to improve testability and debuggingAlso add some pytest fixtures and a
MWS.get_params()method