8000 Sweden market added (master branch) by GriceTurrble · Pull Request #203 · python-amazon-mws/python-amazon-mws · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jan 4, 2025. It is now read-only.

Conversation

@GriceTurrble
Copy link
Member

Covers #201 for master branch.

Covers #201 for master branch
@codecov
Copy link
codecov bot commented Aug 21, 2020

Codecov Report

Merging #203 into master will decrease coverage by 1.16%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   46.92%   45.76%   -1.17%     
==========================================
  Files           4        4              
  Lines         635      649      +14     
  Branches       64       69       +5     
==========================================
- Hits          298      297       -1     
- Misses        326      341      +15     
  Partials       11       11              
Impacted Files Coverage Δ
mws/mws.py 43.39% <7.14%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd50c0c...4e3e2ab. Read the comment docs.

Copy link
Member
@Bobspadger Bobspadger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but if we can correct the link to the repo to be https.

I'll make a release for it today.

version = '0.8.9'
homepage = 'https://github.com/python-amazon-mws/python-amazon-mws'
version = '0.8.10'
homepage = 'http://github.com/python-amazon-mws/python-amazon-mws'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be https (be good on the web and all that!)

however, there is a redirect from http -> https so its not a show stopper.

@Bobspadger Bobspadger merged commit 7aa3b50 into master Aug 25, 2020
@GriceTurrble GriceTurrble deleted the task-sweden-market-master branch September 2, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0