This repository was archived by the owner on Jan 4, 2025. It is now read-only.
add all current marketplaces, alphabetize by country code #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 46.92% 46.92%
=======================================
Files 4 4
Lines 635 635
Branches 64 64
=======================================
Hits 298 298
Misses 326 326
Partials 11 11
Continue to review full report at Codecov.
|
Member
There was a problem hiding this comment.
Personally think we should leave UK as an alias to the same destination as GB, unless we have other code passing this key to MWS itself which might cause a break.
Contributor
Author
OK, I'll make that change (both branches) |
GriceTurrble
approved these changes
Feb 27, 2020
GriceTurrble
added a commit
that referenced
this pull request
Feb 27, 2020
Due to recent regions update from #154 .
Merged
GriceTurrble
added a commit
that referenced
this pull request
Mar 1, 2020
Due to recent regions update from #154 .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several more marketplaces have been added since I looked at this last:
https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html