8000 Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py by hegjon Β· Pull Request #97 Β· python/typing_extensions Β· GitHub
[go: up one dir, main page]
Skip to content

Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2022
Merged

Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py #97

merged 3 commits into from
Nov 25, 2022

Conversation

hegjon
Copy link
Contributor
@hegjon hegjon commented Nov 24, 2022

Before

typing_extensions on ξ‚  main via 🐍 v3.10.8
❯ python3 -m build .
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for wheel...
* Building wheel...
Successfully built typing_extensions-4.4.0.tar.gz and typing_extensions-4.4.0-py3-none-any.whl

typing_extensions on ξ‚  main via 🐍 v3.10.8 took 4s
❯ tar tzf dist/typing_extensions-4.4.0.tar.gz
typing_extensions-4.4.0/CHANGELOG.md
typing_extensions-4.4.0/LICENSE
typing_extensions-4.4.0/README.md
typing_extensions-4.4.0/pyproject.toml
typing_extensions-4.4.0/src/test_typing_extensions.py
typing_extensions-4.4.0/src/typing_extensions.py
typing_extensions-4.4.0/PKG-INFO

After

typing_extensions on ξ‚  sdist-test via 🐍 v3.10.8
❯ python3 -m build .
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (flit_core >=3.4,<4)
* Getting dependencies for wheel...
* Building wheel...
Successfully built typing_extensions-4.4.0.tar.gz and typing_extensions-4.4.0-py3-none-any.whl

typing_extensions on ξ‚  sdist-test via 🐍 v3.10.8 took 4s
❯ tar tzf dist/typing_extensions-4.4.0.tar.gz
typing_extensions-4.4.0/CHANGELOG.md
typing_extensions-4.4.0/LICENSE
typing_extensions-4.4.0/README.md
typing_extensions-4.4.0/pyproject.toml
typing_extensions-4.4.0/src/_typed_dict_test_helper.py
typing_extensions-4.4.0/src/test_typing_extensions.py
typing_extensions-4.4.0/src/typing_extensions.py
typing_extensions-4.4.0/PKG-INFO

@ghost
Copy link
ghost commented Nov 24, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@hegjon hegjon changed the title Expand the include expression to include src/_typed_dict_test_helper.py Expand the pyproject.toml sdist include expression to include src/_typed_dict_test_helper.py Nov 24, 2022
@hegjon hegjon mentioned this pull request Nov 24, 2022
Closed
@JelleZijlstra
Copy link
Member

The CI failures are a little mysterious but seem unrelated to this change. I don't have time right now to investigate though.

The change in the PR looks good, thanks!

@hegjon
Copy link
Contributor Author
hegjon commented Nov 25, 2022

Yes, the CI seems to fail during setup and not for this PR

@AlexWaygood AlexWaygood reopened this Nov 25, 2022
@AlexWaygood
Copy link
Member

This might be related: https://twitter.com/hynek/status/1596039449909264385?s=20&t=6k0Z5-nKmqIpXT25e0G-mg

@hegjon
Copy link
Contributor Author
hegjon commented Nov 25, 2022

Did a new tiny PR #98 to see if the same CI issues happens on that too

@hegjon
Copy link
Contributor Author
hegjon commented Nov 25, 2022

This might be related: https://twitter.com/hynek/status/1596039449909264385?s=20&t=6k0Z5-nKmqIpXT25e0G-mg

Maybe ubuntu-latest changed from 20.04 to 22.04?

@hegjon
Copy link
Contributor Author
hegjon commented Nov 25, 2022

Made issue #99 with more details

@JelleZijlstra JelleZijlstra mentioned this pull request Nov 25, 2022
Closed
@JelleZijlstra JelleZijlstra merged commit 0ea104b into python:main Nov 25, 2022
@hegjon hegjon deleted the sdist-test branch November 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hegjon @JelleZijlstra @AlexWaygood
0