8000 [pre-commit.ci] pre-commit autoupdate by pre-commit-ci[bot] · Pull Request #628 · python/typing_extensions · GitHub
[go: up one dir, main page]
Skip to content

[pre-commit.ci] pre-commit autoupdate #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #628

wants to merge 2 commits into from
+9 −14

Conversation

pre-commit-ci[bot]
Copy link
@pre-commit-ci pre-commit-ci bot commented Jul 7, 2025

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
62cdc6e 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.6 → v0.12.2](astral-sh/ruff-pre-commit@v0.9.6...v0.12.2)
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.5.0...v5.0.0)
- [github.com/python-jsonschema/check-jsonschema: 0.33.0 → 0.33.2](python-jsonschema/check-jsonschema@0.33.0...0.33.2)
@AlexWaygood
Copy link
Member

I guess we might want to switch off ruff autofixes in CI for this repo. We're often doing unusual things that ruff won't necessarily understand out of the box; it'll often be better just to ignore the error or disable a certain rule entirely than to accept the usual autofix.

JelleZijlstra
JelleZijlstra reviewed Jul 7, 2025
View reviewed changes
src/test_typing_extensions.py
@@ -1211,7 +1211,7 @@ def test_illegal_parameters_d A7CD o_not_raise_runtime_errors(self):
# Type checkers should reject these types, but we do not
# raise errors at runtime to maintain maximum flexibility
Literal[int]
Literal[Literal[1, 2], Literal[4, 5]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autofix is wrong but the comment above is also wrong; this is legal. See the example in the spec Literal[Literal[Literal[1, 2, 3], "foo"], 5, None].

@Daraan Daraan mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @JelleZijlstra
0