8000 Add more jsonschema pre-commit hooks by AlexWaygood · Pull Request #625 · python/typing_extensions · GitHub
[go: up one dir, main page]
Skip to content

Add more jsonschema pre-commit hooks #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Add more jsonschema pre-commit hooks #625

merged 1 commit into from
Jul 7, 2025

Conversation

AlexWaygood
Copy link
Member

check-readthedocs reports no errors but check-jsonschema complains:

Schema validation errors were encountered.
  .github/workflows/third_party.yml::$.jobs.skip-schedule-on-fork: {'name': 'Check for schedule trigger on fork', 'runs-on': 'ubuntu-latest', 'if': "github.repository == 'python/typing_extensions' || github.event_name != 'schedule'", 'steps': [{'run': True}]} is not valid under any of the given schemas
  Underlying errors caused this.

  Best Match:
    $.jobs.skip-schedule-on-fork: 'uses' is a required property
  Best Deep Match:
    $.jobs.skip-schedule-on-fork.steps[0].run: True is not of type 'string'

  1 other errors were produced. Use '--verbose' to see all errors.

@AlexWaygood AlexWaygood merged commit 01c0bfd into main Jul 7, 2025
72 checks passed
@AlexWaygood AlexWaygood deleted the more-jsonschema-hooks branch July 7, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @srittau
0