Fix various things with Literal
#145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| A side effect of one of the changes is that equality comparisons of `Literal` | ||
| objects will now raise a `TypeError` if one of the `Literal` objects being | ||
| compared has a mutable parameter. (Using mutable parameters with `Literal` is | ||
| not supported by PEP 586 or by any major static type checkers.) |
There was a problem hiding this comment.
Nice dig against pyanalyze :)
There was a problem hiding this comment.
Oh entirely unintentional!! I can take this out if you like :)
JelleZijlstra
approved these changes
Apr 17, 2023
|
Seems like something's broken on 3.9.0. |
AlexWaygood
commented
Apr 17, 2023
A result of python/cpython#19620. I'm looking at it. |
JelleZijlstra
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113. Closes #144.
Backports python/cpython#23294 and python/cpython#23383, both originally by Yurii Karabas.