8000 Support PEP 612 in typing_extensions (Python 3) by Fidget-Spinner · Pull Request #774 · python/typing · GitHub
[go: up one dir, main page]
Skip to content

Support PEP 612 in typing_extensions (Python 3) #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 10, 2021
Merged

Support PEP 612 in typing_extensions (Python 3) #774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
240d811
Update test_typing_extensions.py
Fidget-Spinner Jan 2, 2021
1680523
support python 3
Fidget-Spinner Jan 2, 2021
509158c
add cache
Fidget-Spinner Jan 3, 2021
2fb2051
Merge branch 'master' into pep612
Fidget-Spinner Jan 3, 2021
7e72190
Add much more runtime info for ParamSpec
Fidget-Spinner Apr 6, 2021
a95f435
add repr and pickle tests for paramspec
Fidget-Spinner Apr 6, 2021
a46cf7c
Added runtime introspection for Concatenate
Fidget-Spinner Apr 6, 2021
e94e4e8
fix pickling errors
Fidget-Spinner Apr 6, 2021
dc0bafc
Apply suggestions from Jelle Zijlstra
Fidget-Spinner Apr 8, 2021
659fe4c
Update typing_extensions/src_py3/typing_extensions.py
Fidget-Spinner Apr 8, 2021
149d3c7
Add __hash__ to paramspec
Fidget-Spinner Apr 8, 2021
16078e9
apply suggestions round 2
Fidget-Spinner Apr 9, 2021
7f13032
Add equality tests
Fidget-Spinner Apr 9, 2021
6ce2d02
Add one more small test for Concatenate's __eq__
Fidget-Spinner Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix pickling errors
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Apr 6, 2021
commit e94e4e8cf6751828a190017144dcf3474304aff8
13 changes: 8 additions & 5 deletions typing_extensions/src_py3/test_typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,18 +1875,17 @@ def test_cannot_subscript(self):
with self.assertRaises(TypeError):
TypeAlias[int]

P = ParamSpec('P')
P_co = ParamSpec('P_co', covariant=True)
P_contra = ParamSpec('P_contra', contravariant=True)
class ParamSpecTests(BaseTestCase):

def test_basic_plain(self):
global P
P = ParamSpec('P')
self.assertEqual(P, P)
self.assertIsInstance(P, ParamSpec)

def test_repr(self):
global P, P_co, P_contra
P = ParamSpec('P')
P_co = ParamSpec('P_co', covariant=True)
P_contra = ParamSpec('P_contra', contravariant=True)
P_2 = ParamSpec('P_2')
self.assertEqual(repr(P), '~P')
self.assertEqual(repr(P_2), '~P_2')
Expand Down Expand Up @@ -1922,6 +1921,9 @@ def test_valid_uses(self):

def test_pickle(self):
global P, P_co, P_contra
P = ParamSpec('P')
P_co = ParamSpec('P_co', covariant=True)
P_contra = ParamSpec('P_contra', contravariant=True)
for proto in range(pickle.HIGHEST_PROTOCOL):
with self.subTest('Pickle protocol {proto}'.format(proto=proto)):
for paramspec in (P, P_co, P_contra):
Expand Down Expand Up @@ -1953,6 +1955,7 @@ def test_valid_uses(self):
C4 = collections.abc.Callable[Concatenate[int, T, P], T]

def test_basic_introspection(self):
P = ParamSpec('P')
C1 = Concatenate[int, P]
C2 = Concatenate[int, T, P]
self.assertEqual(C1.__origin__, Concatenate)
Expand Down
2 changes: 1 addition & 1 deletion typing_extensions/src_py3/typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2363,7 +2363,7 @@ def __getitem__(self, parameters):
return _concatenate_getitem(self, parameters)

Concatenate = _ConcatenateAliasBase(_root=True)

# For 3.5.0 - 3.5.2
else:
class _ConcatenateAliasMeta(typing.TypingMeta):
"""Metaclass for Concatenate."""
Expand Down
0